[fix/feat:ui] Make selected menu checks blue#3234
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved Pure UI styling change that adds a hideIndicator prop to menu items and uses custom blue checkmarks for selected state indication. No runtime behavior changes - only visual presentation. You can customize Macroscope's approvability policy. Learn more. |
What changed
Right-side selected checkmarks now use the blue selected-state color.
Why
It gives the UI some color so its not all grayscale!
UI changes
Before:
After:
Checklist
Testing
vp check apps/web/src/components/chat/TraitsPicker.tsx apps/web/src/components/chat/ChatComposer.tsxNote
Replace radio indicators with blue check icons for selected menu items
CheckIconto selected items in the runtime mode dropdown (ChatComposer.tsx) and trait picker menus (TraitsPicker.tsx), replacing the default radio indicator.MenuRadioItemin menu.tsx with ahideIndicatorprop that collapses the indicator column and switches to a single-column layout when set.Macroscope summarized 800412d.
Note
Low Risk
Visual-only changes to composer dropdowns and shared menu primitives; selection behavior and state wiring are unchanged.
Overview
Selected options in the runtime mode dropdown and traits menus now show a blue
CheckIconon the right instead of the default left radio/check indicator.MenuRadioItemgains ahideIndicatorprop (same idea asSelectItem) so callers can drop the built-in indicator column and render their own selection affordance. Traits select/boolean groups and runtime modeSelectItems usehideIndicatorplustext-blue-400checks aligned to the trailing edge.Reviewed by Cursor Bugbot for commit 800412d. Bugbot is set up for automated code reviews on this repo. Configure here.